PlacementAnnealer class #2800
Merged
PlacementAnnealer class #2800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
vaughnbetz
reviewed
Nov 12, 2024
Contributor
vaughnbetz
left a comment
vaughnbetz
left a comment
There was a problem hiding this comment.
Nice update! Some feedback suggestions attached.
| get_bp_state_globals()->get_glob_breakpoint_state()->blocks_affected_by_move.clear(); | ||
| for (size_t i = 0; i < blocksAffected.moved_blocks.size(); i++) { | ||
| //size_t conversion is required since block_num is of type ClusterBlockId and can't be cast to an int. And this vector has to be of type int to be recognized in expr_eval class | ||
| BreakpointState* bp_state = get_bp_state_globals()->get_glob_breakpoint_state(); |
Contributor
There was a problem hiding this comment.
If we were able to move the breakpiont state inside a placer context it would be cleaner I think. You don't have to do that if you can't see a clean way to do it though ....
…TY_TIMING_PLACE is checked first
github-actions
bot
added
the
libarchfpga
Contributor
Author
|
titan_quick_qor
|
Contributor
AlexandreSinger
left a comment
AlexandreSinger
left a comment
There was a problem hiding this comment.
Hi @soheilshahrouz , great PR! I have a couple of minor comments. I like the interface!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR encapsulates simulated annealing functions and objects into a class.