Skip to content

Gitignore public workflow manifests #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pranaygp wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Gitignore public workflow manifests #1683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62784ec
Write colocated gitignore for custom manifests
pranaygp Apr 10, 2026
2ac6942
Gitignore public workflow manifests
pranaygp Apr 10, 2026
e5763f1
Scope manifest gitignore fix to public outputs
pranaygp Apr 10, 2026
ec0b575
Merge branch 'main' into pranaygp/codex/colocated-manifest-gitignore
pranaygp Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/ignore-generated-manifest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@workflow/builders": patch
"@workflow/next": patch
"@workflow/sveltekit": patch
---

Write colocated `.gitignore` files for public workflow manifests generated by `WORKFLOW_PUBLIC_MANIFEST=1`
1 change: 1 addition & 0 deletions packages/builders/src/vercel-build-output-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ export class VercelBuildOutputAPIBuilder extends BaseBuilder {
'static/.well-known/workflow/v1'
);
await mkdir(staticManifestDir, { recursive: true });
await writeFile(join(staticManifestDir, '.gitignore'), '*');
await copyFile(
join(workflowGeneratedDir, 'manifest.json'),
join(staticManifestDir, 'manifest.json')
Expand Down
4 changes: 4 additions & 0 deletions packages/next/src/builder-deferred.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,6 +640,10 @@ export async function getNextBuilderDeferred() {
'public/.well-known/workflow/v1'
);
await mkdir(publicManifestDir, { recursive: true });
await this.writeFileIfChanged(
join(publicManifestDir, '.gitignore'),
'*'
);
Comment on lines +643 to +646
await this.copyFileIfChanged(
manifestFilePath,
join(publicManifestDir, 'manifest.json')
Expand Down
1 change: 1 addition & 0 deletions packages/next/src/builder-eager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ export async function getNextBuilderEager() {
'public/.well-known/workflow/v1'
);
await mkdir(publicManifestDir, { recursive: true });
await writeFile(join(publicManifestDir, '.gitignore'), '*');
await copyFile(
join(workflowGeneratedDir, 'manifest.json'),
join(publicManifestDir, 'manifest.json')
Expand Down
1 change: 1 addition & 0 deletions packages/sveltekit/src/builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ export class SvelteKitBuilder extends BaseBuilder {
'static/.well-known/workflow/v1'
);
await mkdir(staticManifestDir, { recursive: true });
await writeFile(join(staticManifestDir, '.gitignore'), '*');
await copyFile(
join(workflowGeneratedDir, 'manifest.json'),
join(staticManifestDir, 'manifest.json')
Expand Down
2 changes: 1 addition & 1 deletion workbench/example/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
manifest.js
manifest.js
Loading