[flight-booking-agent] Add multi-turn chat, cancel action, sleep & approval tools#22
Closed
VaguelySerious wants to merge 82 commits intomainfrom
Closed
[flight-booking-agent] Add multi-turn chat, cancel action, sleep & approval tools#22VaguelySerious wants to merge 82 commits intomainfrom
VaguelySerious wants to merge 82 commits intomainfrom
Conversation
Updated instructions for cloning the repository.
* feat: add nuxt example * lockfile
Update nextJS to patched versions and update workflows to beta-27
* basic express + workflow * proper express w/nitro * add workflow to transcode audio * remove fluent-static in place of system ffmpeg * use sandbox to run ffmpeg * use streams over buffers * Update readme + wav handling * rename output * update readme * update typo + upgrade workflow * convert to multi-steps * separate sandbox impl into streams * update tsconfig + imports * remove middleware * update readme and fix * update readme * update readme * update readme * tweaks --------- Co-authored-by: Adrian Lam <me@adriandlam.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
|
|
||
| // If we have output, the approval has been processed | ||
| if (output) { | ||
| try { |
Contributor
There was a problem hiding this comment.
executeBookingApproval returns plain string but BookingApproval component expects JSON with nested structure, causing JSON.parse to fail
| } | ||
|
|
||
| const handleSubmit = async (approved: boolean) => { | ||
| setIsSubmitting(true); |
Contributor
There was a problem hiding this comment.
The booking approval submission lacks error handling and user feedback - failed API requests are silently ignored
Comment on lines
298
to
307
| async function executeBookingApproval( | ||
| { | ||
| flightNumber, | ||
| passengerName, | ||
| }: { flightNumber: string; passengerName: string; price: number }, | ||
| { toolCallId }: { toolCallId: string } | ||
| ) { | ||
| // Note: No "use step" here - hooks are workflow-level primitives | ||
| // Use the toolCallId as the hook token so the UI can reference it | ||
| const hook = bookingApprovalHook.create({ token: toolCallId }); |
Contributor
There was a problem hiding this comment.
Suggested change
| async function executeBookingApproval( | |
| { | |
| flightNumber, | |
| passengerName, | |
| }: { flightNumber: string; passengerName: string; price: number }, | |
| { toolCallId }: { toolCallId: string } | |
| ) { | |
| // Note: No "use step" here - hooks are workflow-level primitives | |
| // Use the toolCallId as the hook token so the UI can reference it | |
| const hook = bookingApprovalHook.create({ token: toolCallId }); | |
| async function executeBookingApproval({ | |
| flightNumber, | |
| passengerName, | |
| }: { | |
| flightNumber: string; | |
| passengerName: string; | |
| price: number; | |
| }) { | |
| // Note: No "use step" here - hooks are workflow-level primitives | |
| // The Workflow framework automatically manages the hook token and associates it with the tool call | |
| const hook = bookingApprovalHook.create(); |
The executeBookingApproval function signature expects a second parameter { toolCallId }, but the Vercel AI SDK framework only passes a single parameter (the input object) to tool execute functions.
Member
Author
|
Superseeded by #23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseeded by #23