Add support for custom headers in Codeblock#346
Draft
mccabe-david wants to merge 2 commits intovercel:mainfrom
Draft
Add support for custom headers in Codeblock#346mccabe-david wants to merge 2 commits intovercel:mainfrom
mccabe-david wants to merge 2 commits intovercel:mainfrom
Conversation
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| import { remarkCjkAutolinkBoundary } from "./lib/remark/cjk-autolink"; | ||
| import { cn } from "./lib/utils"; | ||
| import packageJson from "./package.json"; | ||
| import { CodeBlock } from "./lib/code-block"; |
Contributor
There was a problem hiding this comment.
Suggested change
| import { CodeBlock } from "./lib/code-block"; |
Unused CodeBlock import on line 33 should be removed from packages/streamdown/index.tsx
| <Code {...props} extraCodeHeader={extraCodeHeader} /> | ||
| ), | ||
| ...components, | ||
| }), |
Contributor
There was a problem hiding this comment.
When extraCodeHeader is provided along with a custom code component via the components prop, the custom component overwrites the wrapped version that passes extraCodeHeader through, causing the extraCodeHeader prop to be lost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I wanted to add a play button in CodeBlock to run the code and update state elsewhere in the app. So, I exposed a new prop to optionally add additional header components in CodeBlock.
Type of Change
Changes Made
Testing
Test Coverage
Screenshots/Demos
Play Button running SQL queries in my app
Checklist
pnpm changeset)Changeset
Additional Notes
This feature could also be added if CodeBlock was exported directly and we added a prop to it.