Conversation
Fixes vercel#8032 Split sessions previously started before the renderer reported their final grid, so shells could draw their first prompt at the default PTY size and then be resized afterward. Prepare split sessions immediately but defer PTY construction until resize events settle, buffering existing-session resizes while the split layout is pending. Run terminal fitting without the old 500 ms delay and clear pending fit work when components unmount. Track Canvas and WebGL renderer addons by xterm instance so their ownership survives React remounts. Dispose renderer addons while xterm's render service is still alive, unpausing and draining deferred resize work first. This avoids the xterm 5.3 teardown ordering error that escaped through the Terms error boundary as a plugin crash or blank screen. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks. I found some issues when adding tmux -CC support, and here's the PR to go along with my plugin that adds tmux & htm support https://github.com/MisterTea/hyper-htm
Fixes #8032
Split sessions previously started before the renderer reported their final grid, so shells could draw their first prompt at the default PTY size and then be resized afterward. Prepare split sessions immediately but defer PTY construction until resize events settle, buffering existing-session resizes while the split layout is pending.
Run terminal fitting without the old 500 ms delay and clear pending fit work when components unmount. Track Canvas and WebGL renderer addons by xterm instance so their ownership survives React remounts.
Dispose renderer addons while xterm's render service is still alive, unpausing and draining deferred resize work first. This avoids the xterm 5.3 teardown ordering error that escaped through the Terms error boundary as a plugin crash or blank screen.