-
Notifications
You must be signed in to change notification settings - Fork 55
Update docs #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update docs #230
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 Build Fix:
The FlagsConfig component is instantiated without the required code prop, which is needed to pass configuration data to the component. The code variable is available in the parent component and should be passed as a prop.
View Details
📝 Patch Details
diff --git a/apps/docs/app/[lang]/(home)/page.tsx b/apps/docs/app/[lang]/(home)/page.tsx
index b48b3b2..b8605ac 100644
--- a/apps/docs/app/[lang]/(home)/page.tsx
+++ b/apps/docs/app/[lang]/(home)/page.tsx
@@ -108,7 +108,7 @@ const HomePage = async ({ params }: HomePageProps) => {
{ditheredHeroFlag ? (
<HeroImage />
) : null}
- <FlagsConfig />
+ <FlagsConfig code={code} />
</OneTwoSection>
<TextGridSection data={textGridSection} />
<CenteredSection
Analysis
Missing required prop in FlagsConfig component
What fails: TypeScript compilation fails in apps/docs/app/[lang]/(home)/page.tsx due to missing required code prop on the <FlagsConfig /> component.
How to reproduce:
cd apps/docs
pnpm run buildResult:
Type error: Property 'code' is missing in type '{}' but required in type 'FlagsConfigProps'.
./app/[lang]/(home)/page.tsx:111:12
111 | <FlagsConfig />
| ^
The fix: The FlagsConfig component requires a code prop (as defined in its type definition). The component is used on line 111 where the code variable is available from the component's async parameters. Passing code={code} to the component satisfies the required prop type.
No description provided.