fix: build errors for examples - #1553
Conversation
| await writeFile(filePath, content) | ||
|
|
||
| if (!process.env.POPULATE_REDIS) { | ||
| if (process.env.POPULATE_REDIS === 'false') { |
There was a problem hiding this comment.
this flips the default, not just the opt-out. before: unset or empty meant skip. now anything that isn't the exact string false populates, so an env without POPULATE_REDIS falls into the try block, hits upstash(), and throws Missing required Upstash credentials of the REST API at line 10. that build used to succeed with just the 1000 hardcoded redirects
probably fine inside this repo since .env is committed with POPULATE_REDIS = true, but anyone copying just the app dir gets a hard build failure where they didn't before. maybe:
const populate = process.env.POPULATE_REDIS
if (populate === 'false' || !populate) {also worth noting this doesn't actually fix the red check — edge-functions-redirects-upstash is still failing and the committed .env keeps it at true, so the new opt-out never gets exercised in CI. I think either set it to false in .env (or as a project env var, since next won't override process.env) or pull this hunk out into its own PR? otherwise it looks fixed but isn't
There was a problem hiding this comment.
I restored population as explicit opt-in with POPULATE_REDIS=true and set the committed .env value to false. Imo it makes more sense to do the skip path by default?
| "type": "module", | ||
| "scripts": { | ||
| "build": "tsc", | ||
| "build": "pnpm --filter @repo/constants build && tsc", |
There was a problem hiding this comment.
turbo.json already has "build": { "dependsOn": ["^build"] }, so turbo run build builds @repo/constants first. with this change it gets built twice on a cold build — once under turbo's cache via ^build, then again as an uncached nested pnpm --filter inside api#build. harmless today since apps/web doesn't import constants, but it rewrites packages/constants/dist outside turbo's knowledge, which is a torn-output risk the moment a second parallel consumer shows up
I think the real issue is that the api project isn't building through turbo from the repo root — there's no vercel.json anywhere under starter/turborepo-with-hono, so it's relying on dashboard settings. redirects-upstash and blob-sveltekit both pin "buildCommand": "pnpm turbo build" in a checked-in vercel.json, seems like the same thing would work here and keeps the dependency expressed in one place
minor, but this also makes the api build pnpm-only while apps/api/README.md still tells people to run npm install && npm run dev
There was a problem hiding this comment.
I've added a pin for the build command in vercel.json do you think that's the way to go here?
…nto ecklf/fix-build-errors
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
There was a problem hiding this comment.
Additional Suggestions:
req.cookies(aRequestCookiesobject) is passed wheregetPersonalizedRewriteexpects aRecord<string, string>, causing a TypeScript build failure.
apibuild fails withTS2307: Cannot find module '@repo/constants'because the workspace dependency is never built beforeapps/api'stscruns.
3 participants
Description
Fixes build failures surfaced while validating the Bun WebSocket example PR:
destination. Useroutes.rewrite()so dynamic destinations are emitted correctly.@vercel/global-configinitialized during module evaluation and failed when no connection string was available during the build. Create the client lazily when handling a request.POPULATE_REDIS=falseopt-out was treated as truthy. Compare the value explicitly so population can be disabled.@repo/constantsbecause the workspace dependency had not been built. Build it before compiling the API..svelte-kitbut omitted the adapter-generated.vercel/output, causing Vercel to report a missing output directory. Include.vercel/output/**in cached build outputs.Vercel project root settings were also corrected for the Services examples; their redeployments now pass.
Verification
pnpmbuilds locally.The Upstash deployment still depends on replacing or disabling its stale Redis endpoint.
Type of Change