feat: load dynamic configuration #184
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
feugy
force-pushed
the
damien/o11y-3535-vercelanalytics-load-dynamic-configuration
branch
from
8aa4282 to
e7bc6e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖖 What's in there?
This PR introduce loads a stringified configuration when injecting the script, which acts as defaults for unspecified properties.
This mechanism is a generic way for Vercel to configure at build time
@vercel/analyticsand other "client side" packages, while allowing users to override the configuration when needed.This PR also introduce dedicated data attribute for the injected script:
data-event-endpointanddata-view-endpoint.Finally, it replaces eslint+prettier with biome, and husky+lint-staged with lefthook, and restore unit tests in CI.
TODO server side tracking support, add more tests
🤺 How to test?
🔬Notes to reviewers
Work in progress.
All changes on test apps are due to biome's linter and formatter.