Skip to content

Honor --no-size-check in CLI volume creation #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
idrassi merged 2 commits into from
Jun 14, 2026
+8 −5
Merged

Honor --no-size-check in CLI volume creation #1756

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dbc718
Honor --no-size-check when creating file containers via the CLI
Jun 10, 2026
177ec1f
Fix max volume size handling with no-size-check
idrassi Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/Main/TextUserInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,10 @@ namespace VeraCrypt
if (options->Type == VolumeType::Normal && wxDirExists(parentDir) && wxGetDiskSpace (parentDir, nullptr, &diskSpace))
{
AvailableDiskSpace = (uint64) diskSpace.GetValue ();
if (maxVolumeSize > AvailableDiskSpace)
// Honor --no-size-check so a (sparse) file container larger than the
// current free space can be created from the command line, mirroring
// the GUI wizard behavior (see VolumeSizeWizardPage.cpp).
if (maxVolumeSize > AvailableDiskSpace && !CmdLine->ArgDisableFileSizeCheck)
maxVolumeSize = AvailableDiskSpace;
}
}
Expand All @@ -779,8 +782,8 @@ namespace VeraCrypt
else if (AvailableDiskSpace)
{
// caller requesting maximum size
// we use maxVolumeSize because it is guaranteed to be less or equal to AvailableDiskSpace for outer volumes
options->Size = maxVolumeSize;
// Limit "max" to available disk space even when --no-size-check allows explicit sparse sizes beyond it.
options->Size = VC_MIN (maxVolumeSize, AvailableDiskSpace);
}
else
{
Expand Down Expand Up @@ -808,8 +811,8 @@ namespace VeraCrypt
else if (AvailableDiskSpace)
{
// caller requesting maximum size
// we use maxVolumeSize because it is guaranteed to be less or equal to AvailableDiskSpace for outer volumes
options->Size = maxVolumeSize;
// Limit "max" to available disk space even when --no-size-check allows explicit sparse sizes beyond it.
options->Size = VC_MIN (maxVolumeSize, AvailableDiskSpace);
}
else
{
Expand Down
Loading