Conversation
|
@vugacomat I reviewed the diff carefully with the help of tools. There are useful improvements here but the PR needs changes before it can be merged. The main blocking issue is that several translated Vietnamese strings still have
There are also some terminology consistency issues. The PR changes many occurrences of VeraCrypt "Volume" from the existing Vietnamese wording The same consistency concern appears in a smaller number of keyfile/security-token strings, where the PR introduces "Tệp khóa" and "Thẻ bảo mật" while the file still mostly uses the existing terminology. A few strings also need correction:
Structurally, the XML is valid, there are no missing or duplicate keys and the update does improve some existing translations. Once the issues above are fixed, this can be reviewed again. |
| <entry lang="en" key="IDT_PIM">Số PIM của ổ đĩa:</entry> | ||
| <entry lang="en" key="IDT_OLD_PIM">Số PIM của ổ đĩa:</entry> |
There was a problem hiding this comment.
these entries should contain lang="vi"
| <entry lang="vi" key="IDC_COPY_WIZARD">Thêm Trợ lý Cấu tạo Tập đĩa VeraCrypt vào</entry> | ||
| <entry lang="vi" key="IDC_CREATE">Cấu tạo</entry> | ||
| <entry lang="vi" key="IDC_CREATE_VOLUME">Cấu tạo Tập đĩa</entry> | ||
| <entry lang="en" key="IDC_COPY_EXPANDER">Thêm Trình Mở rộng Ổ đĩa VeraCrypt vào</entry> |
There was a problem hiding this comment.
this entry should contain lang="vi"
| <entry lang="en" key="IDM_DEFAULT_MOUNT_PARAMETERS">Tham số Gắn Mặc định...</entry> | ||
| <entry lang="en" key="IDM_DONATE">Ủng hộ ngay...</entry> |
There was a problem hiding this comment.
these entries should contain lang="vi"
| <entry lang="vi" key="IDM_CREATE_HIDDEN_OS">Tạo Hệ điều hành Ẩn...</entry> | ||
| <entry lang="vi" key="IDM_CREATE_RESCUE_DISK">Tạo Đĩa Cứu hộ...</entry> | ||
| <entry lang="vi" key="IDM_CREATE_VOLUME">Tạo Ổ đĩa mới...</entry> | ||
| <entry lang="en" key="IDM_DECRYPT_NONSYS_VOL">Giải mã vĩnh viễn...</entry> |
There was a problem hiding this comment.
this entry should contain lang="vi"
|
@idrassi Consider using Weblate or any collaborative translation service:
Example project: |
Partly update translation and grammar.