Skip to content

chore(config): remove configurable derived annotations - #26262

Merged
pront merged 2 commits into
masterfrom
pront-remove-configurable-derived
Aug 31, 2026
Merged

chore(config): remove configurable derived annotations#26262
pront merged 2 commits into
masterfrom
pront-remove-configurable-derived

Conversation

@pront

@pront pront commented Aug 29, 2026

Copy link
Copy Markdown
Member

Summary

Motivation

#[configurable(derived)] only bypassed the macro-time field-description check. It was not emitted into metadata or consulted during schema generation, which already falls back to the field type's documentation.

Changes

  • remove the field-description compile-time requirement and the derived macro option
  • remove all derived annotations from configuration fields
  • simplify the now-unused virtual-newtype parsing plumbing

Vector configuration

Not applicable. The generated schema and component documentation remain unchanged.

How did you test this PR?

  • generated component documentation from clean master and this branch; tracked output is identical
  • normalized generated configuration schemas from clean master and this branch are identical
  • cargo test -p vector-config (56 passed)
  • cargo fmt --all

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment in the changelog.d directory.
  • No. A changelog fragment is not required.

@github-actions github-actions Bot added domain: sources Anything related to the Vector's sources domain: transforms Anything related to Vector's transform components domain: sinks Anything related to the Vector's sinks domain: core Anything related to core crates i.e. vector-core, core-common, etc labels Aug 29, 2026
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Aug 29, 2026
@pront
pront marked this pull request as ready for review August 31, 2026 13:06
@pront
pront requested a review from a team as a code owner August 31, 2026 13:06
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T13:11:27.976681Z b78df4b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b78df4b2c7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/vector-config-macros/src/ast/field.rs
@pront
pront requested a review from a team as a code owner August 31, 2026 13:16
@github-actions github-actions Bot added the docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team. label Aug 31, 2026
@pront
pront enabled auto-merge August 31, 2026 13:17
@pront
pront added this pull request to the merge queue Aug 31, 2026
@github-actions github-actions Bot removed the docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team. label Aug 31, 2026
Merged via the queue into master with commit a5317d9 Aug 31, 2026
106 checks passed
@pront
pront deleted the pront-remove-configurable-derived branch August 31, 2026 14:42
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: sinks Anything related to the Vector's sinks domain: sources Anything related to the Vector's sources domain: transforms Anything related to Vector's transform components no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants