fix(topology): await removed disk sinks on shutdown - #26238
Open
Jansen-w wants to merge 2 commits into
Open
Conversation
4 tasks
Jansen-w
marked this pull request as ready for review
August 27, 2026 22:24
Jansen-w
force-pushed
the
fix/await-removed-disk-sinks-on-shutdown
branch
from
August 27, 2026 22:28
31c4d7a to
a7eb390
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retain task handles for removed durable disk-buffered sinks that continue draining after configuration reload, and include those tasks in the existing graceful-shutdown wait and deadline handling.
false.References
Related: #26050
Vector configuration
Covered with topology regressions using an active sink and a removed sink with a blocking disk buffer.
How did you test this PR?
cargo clippy --lib --tests -- -D warningscargo fmt --all -- --checkcargo vdev check changelog-fragmentsThe parallel reload suite retains an unrelated existing enrichment-state timing flake; the test passes serially and in isolation.
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.Contributor Guidelines