Skip to content

chore(http): remove no-proxy dependency - #26204

Merged
pront merged 2 commits into
masterfrom
pront-remove-no-proxy-dependency
Aug 26, 2026
Merged

chore(http): remove no-proxy dependency#26204
pront merged 2 commits into
masterfrom
pront-remove-no-proxy-dependency

Conversation

@pront

@pront pront commented Aug 25, 2026

Copy link
Copy Markdown
Member

Summary

Motivation

The no-proxy crate served us well for a while. In the context of the HTTP v1 migration, we prefer owning this small contract in Vector to give the transport migration direct control over its proxy-routing behavior.

Changes

This implementation was LLM generated. It changes the underlying implementation and it preserves the usage behavior. Regression tests cover wildcard, host, dotted-host, host-and-port, IPv4, IPv6, CIDR, whitespace, deduplication, and serialization behavior.

References

Vector configuration

No configuration changes. Existing configurations such as the following retain the same shape and behavior:

proxy:
  enabled: true
  http: http://127.0.0.1:3128
  https: http://127.0.0.1:3128
  no_proxy:
    - localhost
    - 127.0.0.1
    - 192.168.0.0/16

How did you test this PR?

  • make test (3,617 passed, 13 skipped)
  • cargo test -p vector http::transport_tests --lib -- --test-threads=1 (26 passed)
  • cargo test -p vector-core (251 passed; doctests: 1 passed, 1 ignored)
  • cargo test -p vector-config (45 passed)
  • make check-clippy
  • make check-fmt
  • make check-generated-docs with repository-pinned CUE 0.17.1 (248 examples passed, 4 skipped)
  • make build-licenses
  • make check-licenses
  • cargo tree -i no-proxy confirms the package is absent from the dependency graph.

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. This is an internal dependency replacement with no intended configuration or runtime behavior change.

Contributor Guidelines

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them. To catch issues early, add a pre-push hook (template) or run the following locally before pushing:
    • make fmt
    • make check-clippy (auto-fix with make clippy-fix)
    • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.

@github-actions github-actions Bot added the domain: core Anything related to core crates i.e. vector-core, core-common, etc label Aug 25, 2026
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Aug 25, 2026
@pront
pront marked this pull request as ready for review August 25, 2026 18:12
@pront
pront requested a review from a team as a code owner August 25, 2026 18:12
@pront
pront added this pull request to the merge queue Aug 26, 2026
Merged via the queue into master with commit faf822b Aug 26, 2026
82 checks passed
@pront
pront deleted the pront-remove-no-proxy-dependency branch August 26, 2026 17:35
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: core Anything related to core crates i.e. vector-core, core-common, etc no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants