fix(topology): remove metrics for retired components - #26144
Draft
Jansen-w wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
domain: topology
gwenaskell
reviewed
Aug 19, 2026
| self.refresh_confinement_gauges(); | ||
| let metrics = crate::metrics::Controller::get() | ||
| .expect("Metrics must be initialized before reloading the topology"); | ||
| for (key, kind) in diff.removed_components() { |
Contributor
There was a problem hiding this comment.
when we reach this breakpoint, a processor/sink removed from the topology may still be running and producing metrics. The topology runner only controls the state of sources, so trying to override the state of the metrics registry might cause unexpected behavior. The registry should automatically discard metrics after their TTL expired
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove component-scoped internal metrics after a component is removed by a successful topology reload. Registry cleanup matches both
component_idandcomponent_kind, removes counters, gauges, and histograms, and clears their metric-recency bookkeeping so a later component with the same identity starts cleanly.Cleanup runs only after the replacement topology is installed, preserving metrics when a reload fails and the previous topology is restored.
References
None.
Vector configuration
No new configuration is required. The regression test reloads a basic source-transform-sink topology after removing the transform.
How did you test this PR?
cargo test -p vector-core metrics::tests --no-default-featurescargo test -p vector --lib topology_removes_metrics_for_removed_componentcargo test -p vector --lib topology_remove_one_transformcargo clippy -p vector-core --lib --tests --no-default-features -- -D warningscargo clippy -p vector --lib -- -D warningscargo fmt --all -- --checkcargo vdev check changelog-fragmentsIs this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.