fix(windows_event_log): soft bookmark resume before future-events fallback - #26125
Open
VedantMadane wants to merge 2 commits into
Open
fix(windows_event_log): soft bookmark resume before future-events fallback#26125VedantMadane wants to merge 2 commits into
VedantMadane wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
domain: sources
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
VedantMadane
force-pushed
the
fix-wel-soft-bookmark-resubscribe-26120
branch
from
August 17, 2026 10:49
75ad7da to
86ba467
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #26120.
When strict EvtSubscribeStartAfterBookmark|Strict fails (e.g. ERROR_NOT_FOUND), the previous path fell straight through to EvtSubscribeToFutureEvents when read_existing_events = false, dropping events between the last bookmark and now.
Insert a soft bookmark resume (StartAfterBookmark without Strict) before the last-resort future/oldest flags so recovery prefers continuity over a hard reset. Some re-delivery is possible; silent loss is not.
Test plan