Skip to content

docs: fix broken REVIEWING.md links in SECURITY.md#25833

Open
kobihikri wants to merge 1 commit into
vectordotdev:masterfrom
kobihikri:fix-security-md-reviewing-link
Open

docs: fix broken REVIEWING.md links in SECURITY.md#25833
kobihikri wants to merge 1 commit into
vectordotdev:masterfrom
kobihikri:fix-security-md-reviewing-link

Conversation

@kobihikri

@kobihikri kobihikri commented Jul 14, 2026

Copy link
Copy Markdown

What this fixes

SECURITY.md links to the reviewing guide three times using a repo-root-relative path, but the file actually lives in docs/, so all three links 404:

  • line 95 — [Reviewing guide](REVIEWING.md)
  • line 128 — [reviewing](REVIEWING.md)
  • line 179 — [Reviewing guide](REVIEWING.md#dependencies)

Since SECURITY.md is at the repo root, GitHub resolves these to /blob/master/REVIEWING.md, which doesn't exist. This PR points them at docs/REVIEWING.md (the real location).

Verification

$ curl -s -o /dev/null -w '%{http_code}\n' https://raw.githubusercontent.com/vectordotdev/vector/<head>/REVIEWING.md        # 404
$ curl -s -o /dev/null -w '%{http_code}\n' https://raw.githubusercontent.com/vectordotdev/vector/<head>/docs/REVIEWING.md   # 200

Docs-only change, three link paths, no content edits. The security policy relies on the "dependency review" section it links to, so the fix keeps that guidance reachable.

Disclosure: I used an AI tool to help spot this and prepare the change; I verified the paths against the repo myself and take responsibility for it.

@kobihikri
kobihikri requested review from a team as code owners July 14, 2026 14:25
@github-actions github-actions Bot added the docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team. label Jul 14, 2026
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Before we can merge this PR, please sign our Contributor License Agreement.

To sign, copy and post the phrase below as a new comment on this PR.

Note: If the bot says your username was not found, the email used in your git commit may not be linked to your GitHub account. Fix this at github.com/settings/emails, then comment recheck to retry.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@datadog-vectordotdev

datadog-vectordotdev Bot commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

🚦 2 Pipeline jobs failed

CLA Assistant | CLAAssistant   View in Datadog   GitHub Actions

Changelog | validate-changelog   View in Datadog   GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e710abc | Docs | Give us feedback!

@kobihikri

kobihikri commented Jul 14, 2026 via email

Copy link
Copy Markdown
Author

@pront

pront commented Jul 14, 2026

Copy link
Copy Markdown
Member

I have read the CLA Document and I hereby sign the CLA .
…
On Tue, 14 Jul 2026 at 17:25 datadog-vectordotdev[bot] < @.> wrote: datadog-vectordotdev[bot] left a comment (vectordotdev/vector#25833) <#25833 (comment)> [image: Pipelines] https://cose.datadoghq.com/ci/pipeline-executions?query=ci_level%3Ajob+%40ci.status%3Aerror+%40git.commit.sha%3Ae710abc077a1f279f8fca17b2c3dd056a97e893a&referrer=pr-comment&start=1784037279000 ⚠️ Warnings 🚦 1 Pipeline job failed CLA Assistant | CLAAssistant [image: View in Datadog] https://cose.datadoghq.com/ci/pipeline-executions?query=ci_level%3Ajob+ci.job_correlation_id%3A32038bce0102ee9a&referrer=pr-comment&start=1784037279000 [image: GitHub Actions] https://github.com/vectordotdev/vector/actions/runs/29340751738/job/87111532412 Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives. 🔗 Commit SHA: e710abc <e710abc> | Docs https://docs.datadoghq.com/integrations/guide/source-code-integration/#pr-comments | Give us feedback https://forms.gle/ys6MDmdQEeC5pkzWA! — Reply to this email directly, view it on GitHub <#25833?email_source=notifications&email_token=ABB2WAMZERWT2QJN2KEKZMT5EY7G5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJXGAZDQNZZHE42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4970287999>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABB2WAMPWEHM5SS6BHSIEMD5EY7G5AVCNFSNUABFKJSXA33TNF2G64TZHMYTINRTGI3TMNRXHNEXG43VMU5TIOBYGQYDGMBWGEZ2C5QC . You are receiving this because you authored the thread.Message ID: @.>

@kobihikri Thank you. Please just comment the following:

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kobihikri @pront