chore(aws_s3 source): add custom endpoint for sqs#25182
chore(aws_s3 source): add custom endpoint for sqs#25182serge-r wants to merge 1 commit intovectordotdev:masterfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bdbe6b6fbf
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| &self.auth, | ||
| region.clone(), | ||
| endpoint, | ||
| sqs_region, |
There was a problem hiding this comment.
Use S3 region for ingestor region checks
This call now resolves the region from sqs.region, but that returned region is later stored in state.region and compared against s3_event.aws_region in handle_s3_event_record (src/sources/aws_s3/sqs.rs). If a user configures different S3 and SQS regions/endpoints (the new behavior this change enables), events from the S3 bucket region will be rejected as WrongRegion before object fetch, so the override becomes functionally broken for split-region setups.
Useful? React with 👍 / 👎.
|
I have read the CLA Document and I hereby sign the CLA |
Summary
Add ability to separate SQS endpoint from s3 configuration. It's useful for working with local environments like MinIO and ElasticMQ or non-AWS clouds.
Vector configuration
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.