feat(greptimedb sink)!: add support for GreptimeDB v1.0.0#25178
feat(greptimedb sink)!: add support for GreptimeDB v1.0.0#25178thomasqueirozb wants to merge 10 commits intomasterfrom
Conversation
github-actions
bot
added
the
domain: sinks
thomasqueirozb
changed the title
| if let Some(compression) = config.compression.as_ref() { | ||
| let compression = match compression.as_str() { | ||
| "gzip" => Compression::Gzip, | ||
| "zstd" => Compression::Zstd, | ||
| _ => { | ||
| warn!(message = "Unknown gRPC compression type: {compression}, disabled."); | ||
| Compression::None | ||
| } | ||
| }; | ||
| builder = builder.compression(compression); | ||
| } |
There was a problem hiding this comment.
gzip removed. See GreptimeTeam/greptimedb-ingester-rust#54. ChannelConfig::send_compression hardcodes zstd compression
|
@codex review |
github-actions
bot
added
the
domain: external docs
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 215990e992
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e756042764
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| _ => { | ||
| warn!(message = "Unknown gRPC compression type: {compression}, disabled."); | ||
| Compression::None | ||
| warn!( | ||
| message = "GreptimeDB TLS requires ca_file, crt_file, and key_file to all be set. Falling back to a non-TLS connection." | ||
| ); | ||
| ChannelManager::with_config(channel_config) |
There was a problem hiding this comment.
When tls is configured but any of ca_file, crt_file, or key_file is missing, this branch logs a warning and constructs ChannelManager::with_config(...), which disables TLS for the connection. In practice, a user who sets only ca_file (a common server-auth TLS setup) will silently send metric traffic and credentials over plaintext HTTP instead of failing fast, which is both a security and correctness regression from previous behavior. This should return a configuration error rather than transparently downgrading transport security.
Useful? React with 👍 / 👎.
3 participants
Summary
Replace the pinned git dependency on
greptimedb-ingesterwith the published crate v0.16.0 from crates.io. Update integration tests to run against GreptimeDB v1.0.0.Vector configuration
NA
How did you test this PR?
cargo checkmake check-clippy./scripts/run-integration-test.sh int greptimedb(15/15 passing)Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References