fix(cli): validate transform VRL with --no-environment#25161
Draft
fix(cli): validate transform VRL with --no-environment#25161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes
vector validate --no-environmentso it still reports transform VRL and condition compilation errors.The root cause was that
--no-environmentskipped the normal transform build path where these transform-local checks happen. This PR now validates transforms through their normalbuild()path during--no-environment, while explicitly skippingaws_ec2_metadatabecause itsbuild()currently performs environment-dependent work.Vector configuration
How did you test this PR?
vector validate --no-environmentwith an invalid remap program.build()path.aws_ec2_metadatais skipped during--no-environmentvalidation.cargo test --test integration --features cli-tests validate_no_environment_ -- --nocapturemake fmtmake check-clippy./scripts/check_changelog_fragments.shChange Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
aws_ec2_metadataremains a targeted exception because itsbuild()currently performs network initialization.changelog.d/15037_validate_no_environment_vrl.fix.md.