feat(honeycomb sink): add samplerate_field config option#25141
Open
fru1tworld wants to merge 3 commits intovectordotdev:masterfrom
Open
feat(honeycomb sink): add samplerate_field config option#25141fru1tworld wants to merge 3 commits intovectordotdev:masterfrom
fru1tworld wants to merge 3 commits intovectordotdev:masterfrom
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
samplerate_fieldconfiguration option to the Honeycomb sink. When set, the specified field is extracted from each event and sent as thesampleratevalue in the Honeycomb Batch API. The field is removed from the event data. If the field is missing or not an integer,samplerateis omitted.Closes #18098
Vector configuration
How did you test this PR?
cargo test -p vector --lib -- sinks::honeycomb::tests::samplerate(6/6 pass)make check-clippypassmake check-fmtpassChange Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
samplerateproperty in the Honeycomb sink #18098