fix(aws_cloudwatch_logs sink): Skip healthcheck for templated group names#25128
Open
iandelahorne wants to merge 5 commits intovectordotdev:masterfrom
Open
fix(aws_cloudwatch_logs sink): Skip healthcheck for templated group names#25128iandelahorne wants to merge 5 commits intovectordotdev:masterfrom
iandelahorne wants to merge 5 commits intovectordotdev:masterfrom
Conversation
…ames
If the log group name is templated, exit the healthcheck with Ok before attempting to verify that it
exists. Previous behaviour tried to call `describe_log_groups` on a template string (`{{ cloudwatch_log_group }}`) which resulted in an error from the Cloudwatch service as curly braces aren't part of a valid log group name, and the healthcheck didn't handle this error.
Additionally, add a test for the healthcheck when the log group doesn't exist and create_missing_group is false.
Fixes vectordotdev#10787
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If the log group name is templated, exit the healthcheck with Ok before attempting to verify that it exists. Previous behaviour tried to call
describe_log_groupson a template string ({{ cloudwatch_log_group }}) which resulted in an error from the Cloudwatch service as curly braces aren't part of a valid log group name, and the healthcheck didn't handle this error.Additionally, add a test for the healthcheck when the log group doesn't exist and create_missing_group is false.
Vector configuration
How did you test this PR?
Besides the unit tests, this branch with the above config produces the logs:
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Closes: #10787
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.