feat: add E2E tests for EIP-7951 (secp256r1 P-256 verify precompile)#10
Merged
feat: add E2E tests for EIP-7951 (secp256r1 P-256 verify precompile)#10
Conversation
BenderVeChain
approved these changes
Apr 13, 2026
Collaborator
BenderVeChain
left a comment
There was a problem hiding this comment.
LGTM. Bytecode verified, all five test cases are correct, and the updated WrongInputLength test now covers both too-short (100 bytes) and too-long (192 bytes) inputs with explicit gas assertions (GasUsed=6900). No outstanding issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/eip7951package with 5 E2E tests covering the secp256r1 (P-256) signature verification precompile added at the INTERSTELLAR fork (implement eip-7951: add secp256r1 verify precompile thor#1602)Tests Added
P256VerifyGas = 6900post-fork, 0 pre-forkstaticcall; valid sig → returns 1, invalid sig → returns 0Test Plan
make testgo vetpasses