Repository navigation
fix(cli): confirm Account ownership before completing app claims - #109
Open
callumflack wants to merge 21 commits into
Open
callumflack wants to merge 21 commits into
callumflack wants to merge 21 commits into
Conversation
* feat(connectors): build and verify local connectors with Factory * fix(pdpp): release collection locks on ordinary cancellation * test(cli): isolate legacy export command budgets
* fix(connectors): expose public Factory installation guidance * fix(ci): isolate registry fixtures and publish reviewed Factory artifact
## [0.45.1](v0.45.0...v0.45.1) (2026-10-29) ### Bug Fixes * **connectors:** expose public Factory installation guidance ([#110](#110)) ([35fe808](35fe808))
## [0.45.2](v0.45.1...v0.45.2) (2026-10-29) ### Bug Fixes * **connectors:** pin the compatible public Factory patch ([#111](#111)) ([37af3b6](37af3b6))
## [0.46.0](v0.45.2...v0.46.0) (2026-10-29) ### Features * **cli:** make an existing app available on mainnet (BUI-938) ([f7b26f8](f7b26f8)) ### Bug Fixes * **ci:** validate the dev CLI with its Node 24 runtime ([e752b55](e752b55)) * **cli:** support checking mainnet registration on dev Account ([fe55c10](fe55c10)) * **cli:** wait for mainnet confirmation before Account association ([789175b](789175b)) * **docs:** isolate transcript capture from browsers and live services ([a3bff33](a3bff33)) * **docs:** keep Linux schedule reads inside transcript fixtures ([f6e95a7](f6e95a7)) * **server:** use the dev runtime for own-app reads ([5169937](5169937))
Interactive installation now opens the approved welcome and continues through the searchable source picker, missing-source name, connector decision and guide handoff. Source search shows 12 rows with a persistent Ctrl+O shortcut; choosing Build exits successfully with the guide visible. Automated installs remain prompt-free and agent skill installation stays optional. Built directly on v0.46.0. Preserves the shipped public Factory 0.0.2 instructions, adapter and BUI-938 behavior. Extracts only onboarding from #106; no BUI-945 funding or collection-readiness changes are included. Validation: full validate (976 tests), CLI preflight, npm package and standalone integrity checks, clean structured closeout review. A fresh piped standalone install in a disposable PTY/home completed all five approved screens using the populated public catalog and Readwise, then exited 0 without sign-in, agent installation, provider access or funding. The same PTY regression now runs in the existing Unix installer CI smoke lane.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vana app claimpreviously reported success after generating a browser link, before Account had confirmed ownership. It now reports completion only after the existing Account ownership endpoint confirms the app belongs to the intended Account.--resumepreserves the app, Account context and signed handoff; pending human action exits 7, unavailable confirmation exits 6 and confirmed ownership exits 0.BUI-936 claim confirmation: done on Account-dev
Account support is already merged to dev in Account PR #1981, deployed at
e0dd526141d8ddb04a8c535b175770ecd5654fc2. Live checks ran on 29 October 2026, 06:12–06:15 UTC, using this PR's candidateeb47a46a6899e8945f8cb765303655e70069d085,https://dp-rpc-dev.vana.org, networkmoksha, andhttps://account-dev.vana.org.not_owned. CLI returned exit 7 and a signed link. After the real Account-dev browser claim, the CLI returned exit 0 and a separate ownership read confirmedownedfor the intended Account.--resumeprocess retained the exact signed link, app and Account while stillnot_owned. Claimed through that retained link in Account-dev, then--resumereturned exit 0 and an independent ownership read confirmedownedfor the original Account.Both named Testnet apps remain in Account-dev for inspection. No funding, consent, collection or paid read occurred. The existing demo/key and other chat's work were preserved.
Validation on current main — 30 October 2026
Updated against main v0.47.0, preserving the newer mainnet registration flow and network-scoped app profiles. The update retains the original claim commit and can be pushed without rewriting its history.
pnpm validate: 983 tests across 70 files, TypeScript, ESLint and formatting passed.app claim --helppassed. Published implementation and tests match the tested local candidate; only the worklog was subsequently updated.eb47a46head. No new live claim, funding, consent, collection or paid read was performed.Delivery state
Leave this PR open and unmerged, targeting the existing CLI
mainbranch. Auto-merge is off. No production merge or CLI release. This is completed claim-confirmation implementation and live dev acceptance, not a published CLI release. Merging this PR tomainwould trigger the CLI release workflow.Only BUI-936 claim confirmation, resume, tests and matching docs are included. Funding and mainnet-transition work are excluded. The broader BUI-936 remains open for its separate obligations.
Created with Codex.