Repository navigation
feat(connectors): build and verify local connectors with Factory - #108
Merged
Merged
Conversation
Contributor
|
🎉 This PR is included in version 0.45.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
volod-vana
added a commit
that referenced
this pull request
Oct 29, 2026
Resolve conflicts with the Factory connector build (#108/#110/#111), mainnet app registration (BUI-938) and the approved onboarding (#112). - Welcome, source picker and missing-source flow follow main's approved screens; `vana skills setup` keeps this PR's three-skill offer. - Create Connector keeps main's Factory workflow and adds this PR's CLI bootstrap, discovery and collect-through-Vana readiness guidance; the deleted legacy references are no longer mentioned (version 1.4.0). - Builder keeps this PR's description (version 1.2.1). - README and LOG keep both sides' sections. - Ingest-failure tests keep main's gated cases with this PR's readiness setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 22 CI repair in
698160bsplits the legacy-receipt sync, inspection, and recollection contracts into independent subprocess cases with real collection setup. The five-second timeout is unchanged. No production, retry, skip, or concurrency changes. Full Node 22 validation passed all 952 tests.The cancellation review finding is fixed in
c225591. Every collection holding the lock shares graceful SIGINT/SIGTERM cleanup. Subprocess regressions prove saved-byte preservation, provider cleanup, lock release, and successful subsequent collection.Why
An agent using Vana cannot currently use Factory to create a missing connector and then finish collection. This adds the local adapter while keeping the current agent responsible for implementation and repair.
What changed
Scope
Blast Radius
Factory-bound local collection uses the new gate. Existing collection and server-sync owners retain accepted-byte and identity checks. The external Factory host requires Node 24+ on macOS/Linux; other CLI commands retain their runtime support.
Verification
Refs BUI-951.
Companion Factory PR #2 contains the private core.
Created with Codex and gpt-6.1-sol.