Add events page intro (meetup, asana form), new events, and sort order#504
Add events page intro (meetup, asana form), new events, and sort order#504mtuteja-git wants to merge 1 commit intovalkey-io:mainfrom
Conversation
Signed-off-by: Manvika Tuteja <manvikatuteja16@gmail.com>
|
| var dateStr = monthNames[dateObj.getMonth()] + ' ' + dateObj.getDate() + ', ' + dateObj.getFullYear(); | ||
| var eventMonth = e.date.substring(0, 7); | ||
| var today = new Date().toISOString().substring(0, 10); | ||
| // var today = new Date().toISOString().substring(0, 10); |
There was a problem hiding this comment.
you can remove this if it's no longer needed.
madolson
left a comment
madolson
left a comment
There was a problem hiding this comment.
Sorting improvement is good UX. A few minor things to clean up.
| event_type = "third-party" | ||
| location = "San Francisco, CA, USA" | ||
| external_url = "https://builder.aws.com/content/3BM4ZJR7CsJiD7kytzRthwa3o9G/opensearch-project-and-valkey-bay-area-meetup-april-2026" | ||
| +++ No newline at end of file |
There was a problem hiding this comment.
Missing trailing newline. All existing event files end with a newline after +++. Same issue in all four new event files.
| @@ -0,0 +1,9 @@ | |||
| +++ | |||
| title = "Bay Area OpenSearch + Valkey Meetup - April 2026" | |||
| date = 2026-04-20 | |||
There was a problem hiding this comment.
Existing events use date = 2026-04-09 01:01:01 (with a time component). These new files omit it. Either works for Zola, but should be consistent with the existing convention.
|
|
||
| {% block main_content %} | ||
|
|
||
| <div class="events-intro" style="text-align: center; max-width: 800px; margin: 0 auto 2rem;"> |
There was a problem hiding this comment.
Inline styles — is there a stylesheet where .events-intro could be defined instead? The rest of the page uses CSS classes.
| var allEvents = events.slice().sort(function(a, b) { return b.date.localeCompare(a.date); }); | ||
| var today = new Date().toISOString().substring(0, 10); | ||
| var currentMonth = today.substring(0, 7); | ||
| var thisMonth = events.filter(function(e) { return e.date.substring(0, 7) === currentMonth && e.date >= today; }) |
There was a problem hiding this comment.
nit: thisMonth is slightly misleading since it filters out past days this month. Maybe thisMonthUpcoming or similar.
| var past = events.filter(function(e) { return e.date < today; }) | ||
| .sort(function(a, b) { return b.date.localeCompare(a.date); }); | ||
| var allEvents = thisMonth.concat(upcoming).concat(past); | ||
|
|
There was a problem hiding this comment.
Indentation is off — var allEvents uses 1 space indent while surrounding code uses 2 spaces. Same with the commented-out line below.
2 participants
Description
Linked the form to add more events + linked the meetup charter. Also added more upcoming events like Percona Live, Laracon US, etc.
Issues Resolved
n/a
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.