Skip to content

fix(isMagnetURI): require hexadecimal BitTorrent v2 hashes #2955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wozhenbang2004 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(isMagnetURI): require hexadecimal BitTorrent v2 hashes #2955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bfab50
fix(isMagnetURI): require hexadecimal BitTorrent v2 hashes
wozhenbang2004 Nov 7, 2026
1f1daf6
test(isMagnetURI): cover non-hexadecimal v2 hashes
wozhenbang2004 Nov 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/isMagnetURI.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import assertString from './util/assertString';

const magnetURIComponent = /(?:^magnet:\?|[^?&]&)xt(?:\.1)?=urn:(?:(?:aich|bitprint|btih|ed2k|ed2khash|kzhash|md5|sha1|tree:tiger):[a-z0-9]{32}(?:[a-z0-9]{8})?|btmh:1220[a-z0-9]{64})(?:$|&)/i;
const magnetURIComponent = /(?:^magnet:\?|[^?&]&)xt(?:\.1)?=urn:(?:(?:aich|bitprint|btih|ed2k|ed2khash|kzhash|md5|sha1|tree:tiger):[a-z0-9]{32}(?:[a-z0-9]{8})?|btmh:1220[a-f0-9]{64})(?:$|&)/i;

export default function isMagnetURI(url) {
assertString(url);
Expand Down
17 changes: 17 additions & 0 deletions test/validators.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12771,6 +12771,23 @@ describe('Validators', () => {
});


it('should require hexadecimal BitTorrent v2 magnet hashes', () => {
const hash = '0123456789abcdef'.repeat(4);
test({
validator: 'isMagnetURI',
valid: [
`magnet:?xt=urn:btmh:1220${hash}`,
`magnet:?xt=urn:btmh:1220${hash.toUpperCase()}`,
`magnet:?dn=example&xt.1=urn:btmh:1220${hash}&tr=udp://example.com`,
],
invalid: [
`magnet:?xt=urn:btmh:1220g${hash.slice(1)}`,
`magnet:?xt=urn:btmh:1220${hash.slice(0, -1)}Z`,
`magnet:?dn=example&xt.1=urn:btmh:1220${hash.slice(0, 32)}g${hash.slice(33)}&dn=test`,
],
});
});

it('should validate LatLong', () => {
test({
validator: 'isLatLong',
Expand Down
Loading