Lifecycle management for ExternalSecrets#16
Open
sabre1041 wants to merge 1 commit into
Open
Conversation
sabre1041
force-pushed
the
externalsecrets-lifecycle
branch
from
d10c38f to
ed6ffb9
Compare
Signed-off-by: Andrew Block <andy.block@gmail.com>
sabre1041
force-pushed
the
externalsecrets-lifecycle
branch
from
ed6ffb9 to
ad39ae0
Compare
minmzzhang
reviewed
May 29, 2026
Contributor
minmzzhang
left a comment
minmzzhang
left a comment
There was a problem hiding this comment.
Overall I like this lifecycle management implementation. Just one thing to consider, shall we use a _helper.tpl to extract the repetitive blocks for each template?
| refreshPolicy: Periodic | ||
| annotations: {} | ||
| labels: {} | ||
| adminUser: |
Contributor
There was a problem hiding this comment.
is it keycloak admin user? is it possible to add comments here referencing back to the templates?
| adminUser: | ||
| creationPolicy: Owner | ||
| deletionPolicy: Retain | ||
| refreshPolicy: Periodic |
Contributor
There was a problem hiding this comment.
since we specified the refreshPolicy as Periodic, do we want to add the refreshInterval as configurable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lifecycle management for ExternalSecrets