Skip to content

fix: use HookSucceeded with orphan propagation for oneShot ExternalSecret #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minmzzhang merged 3 commits into from
May 29, 2026
+413 −405
Merged

fix: use HookSucceeded with orphan propagation for oneShot ExternalSecret #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d0fc5c
fix: use HookSucceeded with orphan propagation for oneShot ExternalSe…
minmzzhang May 25, 2026
06c8298
fix: use creationPolicy Orphan instead of deletionPolicy Retain for o…
minmzzhang May 27, 2026
7a5d637
fix: run prettier via podman after helm-docs to pass super-linter
minmzzhang May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ keywords:
- pattern
name: rhbk
type: application
version: 0.0.9
version: 0.0.10
home: https://github.com/validatedpatterns/rhbk-chart
maintainers:
- name: Validated Patterns Team
Expand Down
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# https://hub.docker.com/r/helmunittest/helm-unittest/tags/
HELM_UNITTEST_IMAGE ?= docker.io/helmunittest/helm-unittest:3.14.4-0.5.0
HELM_DOCS_IMAGE ?= docker.io/jnorwood/helm-docs:latest
# https://hub.docker.com/r/jauderho/prettier/tags
PRETTIER_IMAGE ?= docker.io/jauderho/prettier:latest

PWD=$(shell pwd)
MYNAME=$(shell id -n -u)
Expand Down Expand Up @@ -29,6 +31,7 @@ helm-docs: ## Generates README.md from values.yaml
# podman run $(PODMAN_ARGS) -v $(PWD):/helm-docs:rw $(HELM_DOCS_IMAGE) -x
# Then render the README.md file
podman run $(PODMAN_ARGS) -v $(PWD):/helm-docs:rw $(HELM_DOCS_IMAGE)
podman run $(PODMAN_ARGS) -v $(PWD):/work:rw -w /work $(PRETTIER_IMAGE) --write README.md

.PHONY: test
test: helm-lint helm-unittest ## Runs helm lint and unit tests
Expand Down
Loading