Skip to content

Add additionalArgoAdmins support to configmap #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbaldessari merged 1 commit into from
Jul 5, 2026
Merged

Add additionalArgoAdmins support to configmap #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions templates/pattern-operator-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ data:
gitea.helmRepoUrl: {{ .Values.main.gitea.helmRepoUrl }}
gitea.chartVersion: {{ .Values.main.gitea.chartVersion }}
analytics.enabled: {{ .Values.main.analytics.enabled | quote }}
{{- if .Values.main.gitops.additionalArgoAdmins }}
gitops.additionalArgoAdmins: {{ .Values.main.gitops.additionalArgoAdmins }}
{{- end }}

# gitops.sourceNamespace: GitOpsDefaultCatalogSourceNamespace
# gitops.installApprovalPlan: GitOpsDefaultApprovalPlan
Expand Down
15 changes: 15 additions & 0 deletions tests/pattern_operator_configmap_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,21 @@ tests:
path: data["gitops.channel"]
value: bar

- it: Should not include gitops.additionalArgoAdmins by default
asserts:
- notExists:
path: data["gitops.additionalArgoAdmins"]

- it: Should set gitops.additionalArgoAdmins
set:
main:
gitops:
additionalArgoAdmins: "group1,group2"
asserts:
- equal:
path: data["gitops.additionalArgoAdmins"]
value: "group1,group2"

- it: Should set gitea parameters
set:
main:
Expand Down
3 changes: 3 additions & 0 deletions values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ main:
channel: "gitops-1.21"
# -- Source to be used to install the gitops operator from
operatorSource: redhat-operators
# -- Comma-separated list of additional ArgoCD admin groups.
# Only used when argoRBAC is not set.
additionalArgoAdmins: ""

# -- Settings related to the in-cluster gitea installation
gitea:
Expand Down