sync: main to rhdp-deploy - #630
Open
github-actions[bot] wants to merge 10 commits into
Open
Conversation
Gen V4 is supported and has better availability in most regions
feat: Change azure node type to newer generation (v4)
Bumps [ansible/ansible-lint](https://github.com/ansible/ansible-lint) from 26.6.0 to 26.8.0. - [Release notes](https://github.com/ansible/ansible-lint/releases) - [Commits](ansible/ansible-lint@262624c...665d9e0) --- updated-dependencies: - dependency-name: ansible/ansible-lint dependency-version: 26.8.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
The idea is that when we use our default container we try and verify the
container's signature with cosign (if the binary is present, if it is
absent we just warn the user).
We do not error out in case of network issues.
This is what a normal run will look like:
./pattern.sh make install
Verifying image signature for quay.io/validatedpatterns/utility-container...
Image signature verified successfully
Trying to pull quay.io/validatedpatterns/utility-container:latest...
Getting image source signatures
Copying blob ac01a0bd520d [--------------------------------------] 4.0MiB / 569.1MiB | 40.6 MiB/s
Copying blob 7c52896999c7 [=====================>----------------] 22.2MiB / 38.8MiB | 16.7 MiB/s
On macosx which has bash 3.x
michele@Micheles-Mac-mini ~ % bash --version
GNU bash, version 3.2.57(1)-release (arm64-apple-darwin25)
michele@Micheles-Mac-mini ~ % cat /tmp/t.sh
set -euo pipefail
PKI_HOST_MOUNT_ARGS=()
echo "FOO"
echo "${PKI_HOST_MOUNT_ARGS[@]}"
michele@Micheles-Mac-mini ~ % /tmp/t.sh
FOO
/tmp/t.sh: line 6: PKI_HOST_MOUNT_ARGS[@]: unbound variable
Where as the same just works on bash 4.x/5.x:
bash --version
GNU bash, version 5.3.9(1)-release (x86_64-redhat-linux-gnu)
❯ cat /tmp/t.sh
set -euo pipefail
PKI_HOST_MOUNT_ARGS=()
echo "FOO"
echo "${PKI_HOST_MOUNT_ARGS[@]}"
❯ /tmp/t.sh
FOO
❯
We fix this by using the expression:
${VAR_ARRAY[@]+"${VAR_ARRAY[@]}"}
This works both on bash 3.x and also the newer ones. Tested on linux
with bash 5.x and on Mac OSX with bash 3.x
…ons/ansible/ansible-lint-26.8.0 build(deps): bump ansible/ansible-lint from 26.6.0 to 26.8.0
Add a non-blocking image signing verification step
Fix array expansion with bash 3.x
Move comment in the correct place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sync-branches: New code has just landed in main, so let's bring rhdp-deploy up to speed!