Add changes to support pattern uninstall#38
Open
darkdoc wants to merge 5 commits intovalidatedpatterns:mainfrom
Open
Add changes to support pattern uninstall#38darkdoc wants to merge 5 commits intovalidatedpatterns:mainfrom
darkdoc wants to merge 5 commits intovalidatedpatterns:mainfrom
Conversation
Contributor
darkdoc
commented
Feb 3, 2026
darkdoc
commented
- feat: Remove early sync-wave from multiclusterhub
- feat: Pass global deletepattern variable to clustergroup chart
- feat: enable pruning of app of apps (argocd)
- feat: enable pruning of app of apps (acm)
- feat: refactor deletePattern variable
No need for manual sync-wave specified. Removing it for clarity.
This should handle the child app deletion on spoke when the pattern gets deleted.
This should handle the child app deletion on spoke when the pattern gets deleted.
This should handle the app of app deletion on spoke when the pattern gets deleted, in the phase where we remove the acm, and the acm policies
Change variable to string from int (magic number) If acm chart gets deleteSpokeChildApps, it will set, deletePattern to deleteChildApps and pass it to its app of apps (clustergroup chart)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.