Add MailChimp to styles library#6
Open
ChrisChinchilla wants to merge 2 commits intovale-cli:masterfrom
Open
Conversation
pirj
reviewed
Apr 29, 2020
library.json
Outdated
| "name": "MailChimp", | ||
| "description": "A Vale-compatible implementation of the MailChimp Style Guide.", | ||
| "homepage": "https://github.com/testthedocs/MailChimp", | ||
| "url": "https://github.com/errata-ai/Microsoft/releases/latest/download/Microsoft.zip" |
There was a problem hiding this comment.
Shouldn't this be https://github.com/testthedocs/MailChimp/releases/latest/download/MailChimp.zip?
It redirects to https://github.com/testthedocs/MailChimp/archive/0.1.0.zip, but this results in a 404. Accessing this link directly works.
Author
There was a problem hiding this comment.
yes, this needs fixing, I am doing that tomorrow
See the whole discussion in #5
Author
|
@jdkato MailChimp should also now be ready |
themr0c
approved these changes
Jul 20, 2022
Contributor
|
The assets are missing, https://github.com/testthedocs/MailChimp/releases/latest/download/MailChimp.zip does not exist |
Contributor
|
This could help releasing the required MailChimp.zip testthedocs/MailChimp#3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with other PR, I cannot figure out the latest zip archive link