docs: clarify ShortcutAction is registered on Panel or Window #10672 - #12686
Open
AzazelSensei wants to merge 1 commit into
Open
AzazelSensei wants to merge 1 commit into
AzazelSensei wants to merge 1 commit into
Conversation
Generic shortcut actions go on Panel/Window via addActionHandler, not on child fields. Click and focus shortcuts stay on the component.
|
|
1 similar comment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shortcut page mixed "accept" and "can attach" for Panel and Window, and it was not obvious that ShortcutAction goes on those containers rather than on the child component.
I spelled out that you register Action.Handler on Panel or Window with addActionHandler, and that click/focus shortcuts are a different API on the button or field.
Fixes #10672