od: remove unused properties from InputDecoder - #14023
Merged
Merged
Conversation
xtqqczze
reviewed
Aug 19, 2026
| @@ -68,12 +61,11 @@ where | |||
| let (n, p) = self | |||
| .input | |||
| .peek_read(self.data.as_mut_slice(), self.reserved_peek_length)?; | |||
Contributor
There was a problem hiding this comment.
does it make sense to use .map now?
Contributor
Author
There was a problem hiding this comment.
Good point, thanks! I changed it to use map and added @Devel08 as a co-author.
Co-authored-by: Devel <Denislav08@proton.me>
cakebaker
force-pushed
the
od_remove_properties
branch
from
August 19, 2026 12:25
4539298 to
0da745e
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #14006 and removes the properties
used_normal_lengthandused_peek_lengthfromInputDecoderas they are unused.