uucore: share the caret diagnostic plumbing across the utilities - #14019
uucore: share the caret diagnostic plumbing across the utilities#14019sylvestre wants to merge 1 commit into
Conversation
|
GNU testsuite comparison: |
Merging this PR will regress 1 benchmark
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | du_wide_tree[(5000, 500)] |
20 ms | 20.7 ms | -3.16% |
| ⚡ | Simulation | cksum_crc32b |
42.4 ms | 40.8 ms | +3.92% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing caret-uucore-share (7209ddc) with main (f2987b5)2
Footnotes
-
363 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
caret-dd-test-shim(f2987b5) during the generation of this report, somain(f2987b5) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
c2698e0 to
7209ddc
Compare
Adds OptionValue (a value with the option it came from), Snapshot::render_option, list_items and error_after_report, and ports the utilities onto them: four spellings of the value/short/long triple, three identical render() bodies and fifteen copies of the report-then-quiet idiom become one each.
7209ddc to
7d78b08
Compare
Adds OptionValue (a value with the option it came from), Snapshot::render_option,
list_items and error_after_report, and ports the utilities onto them: four
spellings of the value/short/long triple, three identical render() bodies and
fifteen copies of the report-then-quiet idiom become one each.
Stack created with GitHub Stacks CLI • Give Feedback 💬