Skip to content

expr: stop repeating the about line in --help - #14000

Open
MsfPablo wants to merge 1 commit into
uutils:mainfrom
MsfPablo:fix/expr-help-duplicate-about
Open

expr: stop repeating the about line in --help#14000
MsfPablo wants to merge 1 commit into
uutils:mainfrom
MsfPablo:fix/expr-help-duplicate-about

Conversation

@MsfPablo

Copy link
Copy Markdown
Contributor

Fixes #13983.

expr-after-help opened by restating expr-about verbatim, so expr --help printed "Print the value of EXPRESSION to standard output" once as the clap about line and again a few lines down. Dropped the duplicated sentence from the after-help text and kept the part that is actually about the section below it.

Applied to en-US.ftl and fr-FR.ftl, which both carried the same duplication.

GNU's expr --help reads "Print the value of EXPRESSION to standard output. A blank line below separates increasing precedence groups." as one paragraph, but it has no separate about line — clap prints ours already, so keeping only the second sentence gives the same result rather than diverging from GNU.

Print the value of EXPRESSION to standard output

Usage: expr [EXPRESSION]
       expr [OPTIONS]
...
A blank line below separates increasing precedence groups.

EXPRESSION may be:

cargo test --no-default-features --features expr --test tests test_expr: 132 passed.

@codspeed-hq

codspeed-hq Bot commented Aug 18, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 7.07%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
✅ 353 untouched benchmarks
⏩ 50 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation numfmt_stream_to_si_precision 390.9 ms 345.1 ms +13.26%
Simulation numfmt_stream_to_si 431.1 ms 398.2 ms +8.26%
Simulation du_summarize_balanced_tree[(5, 4, 10)] 16.4 ms 15.8 ms +4.03%
Simulation numfmt_to_si_precision[10000] 92.9 ms 90.1 ms +3.03%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing MsfPablo:fix/expr-help-duplicate-about (3b5f861) with main (bfd7c63)

Open in CodSpeed

Footnotes

  1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.
Congrats! The gnu test tests/cp/link-heap is now passing!
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!

@oech3

oech3 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

duplicated PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

expr: Redundunt text for asking --help

2 participants