expr: stop repeating the about line in --help - #14000
Open
MsfPablo wants to merge 1 commit into
Open
Conversation
Merging this PR will improve performance by 7.07%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | numfmt_stream_to_si_precision |
390.9 ms | 345.1 ms | +13.26% |
| ⚡ | Simulation | numfmt_stream_to_si |
431.1 ms | 398.2 ms | +8.26% |
| ⚡ | Simulation | du_summarize_balanced_tree[(5, 4, 10)] |
16.4 ms | 15.8 ms | +4.03% |
| ⚡ | Simulation | numfmt_to_si_precision[10000] |
92.9 ms | 90.1 ms | +3.03% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing MsfPablo:fix/expr-help-duplicate-about (3b5f861) with main (bfd7c63)
Footnotes
-
50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
GNU testsuite comparison: |
Contributor
|
duplicated PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13983.
expr-after-helpopened by restatingexpr-aboutverbatim, soexpr --helpprinted "Print the value of EXPRESSION to standard output" once as the clap about line and again a few lines down. Dropped the duplicated sentence from the after-help text and kept the part that is actually about the section below it.Applied to
en-US.ftlandfr-FR.ftl, which both carried the same duplication.GNU's
expr --helpreads "Print the value of EXPRESSION to standard output. A blank line below separates increasing precedence groups." as one paragraph, but it has no separate about line — clap prints ours already, so keeping only the second sentence gives the same result rather than diverging from GNU.cargo test --no-default-features --features expr --test tests test_expr: 132 passed.