expr: remove redundant about text from after-help - #13987
Open
l46983284-cpu wants to merge 1 commit into
Open
Conversation
The expr utility showed its about text twice in --help output: once from the about field and again at the start of after-help. Remove the duplicated first sentence from expr-after-help in both en-US and fr-FR locales so the help text reads naturally. Fixes uutils#13983.
|
GNU testsuite comparison: |
|
I think it would be better if there was no awkward line break. should typically look like since the sentence doesn't pass over 80 characters. |
Contributor
Author
|
I kept the line break to mirror GNU coreutils style. GNU expr --help has the same break: A blank line below Parity with GNU is the goal here. |
Contributor
Author
|
CI failures are unrelated to this change. The 3 failing GNU tests are in the backport list in util/fetch-gnu.sh — fetched at CI time via curl from raw.githubusercontent.com. Logs show the scripts came down as HTML error pages instead of shell. None of them reference expr. Transient GitHub flake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13983.
The
exprutility showed its about text twice in--helpoutput:once from the
aboutfield and again at the start ofafter-help.Remove the duplicated first sentence from
expr-after-helpin bothen-US and fr-FR locales so the help text reads naturally.
Before:
After: