Skip to content

CI: Fix failures from unused_qualifications#10692

Merged
sylvestre merged 1 commit intouutils:mainfrom
Xylphy:clippy/unused_qualifications
Feb 4, 2026
Merged

CI: Fix failures from unused_qualifications#10692
sylvestre merged 1 commit intouutils:mainfrom
Xylphy:clippy/unused_qualifications

Conversation

@Xylphy
Copy link
Contributor

@Xylphy Xylphy commented Feb 3, 2026

Follow up of #10571

Summary
This PR fixes CI failures caused by newly surfaced unused_qualifications warnings after the previous PR re-enabled the lint. I missed these because the original branch had gone stale and was not fully rebased against recent upstream changes before merge. Sorry for that.

Testing

  • Verified locally on Linux.
  • I haven’t tested on other platforms; CI should confirm if this passes.

@Xylphy Xylphy marked this pull request as draft February 3, 2026 21:45
@oech3 oech3 mentioned this pull request Feb 3, 2026
@sylvestre
Copy link
Contributor

the patch queue doesn't seem to be legit

@aaron-ang
Copy link
Contributor

aaron-ang commented Feb 3, 2026

try git fetch upstream && git rebase upstream/main

you may have to git push --force-with-lease

@Xylphy Xylphy marked this pull request as ready for review February 4, 2026 00:34
@Xylphy
Copy link
Contributor Author

Xylphy commented Feb 4, 2026

CI is green for the lint-related changes in this PR.
The remaining failures are in test jobs and appear unrelated to the unused_qualifications cleanup.

@aaron-ang
Copy link
Contributor

aaron-ang commented Feb 4, 2026

your PR shouldn't reference previous commits in main not authored by you. That's what the rebase is for.

@Xylphy
Copy link
Contributor Author

Xylphy commented Feb 4, 2026

I'll do it later since I'm currently on a class😅
Thanks for the tip

@Xylphy
Copy link
Contributor Author

Xylphy commented Feb 4, 2026

@aaron-ang Doing rebase causes merge conflicts. I'll just create a new local branch from the tip of main then force push to this branch

@Xylphy Xylphy force-pushed the clippy/unused_qualifications branch from d410b67 to 34d280f Compare February 4, 2026 05:10
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit 69f11b3 into uutils:main Feb 4, 2026
148 of 152 checks passed
@Xylphy Xylphy deleted the clippy/unused_qualifications branch February 4, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants