fmt: fix fmt /dev/zero panic #10602
Open
fmt: fix fmt /dev/zero panic #10602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent potential memory exhaustion when processing inputs without newlines or paragraph breaks by adding size limits: - Maximum line length: 1 MiB - Maximum paragraph size: 1
Replace explicit match on Result with if let pattern for cleaner error handling in the buffer fill operation. This change maintains the same logic flow while improving code readability by reducing nesting and using more idiomatic Rust error handling patterns.
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevent unbounded line buffering in fmt by introducing a capped, incremental line reader.
Split oversized paragraphs by byte/line thresholds to keep memory bounded on infinite input.
related
#10580