tee: fix hang on broken stdout pipe in -p mode and add regression test #10599
+59
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #10308
Fix: tee -p (Linux) ensure_stdout_not_broken Can Hang Forever on Pipes
Problem
tee -p hangs indefinitely in normal pipelines (e.g., echo "test" | tee -p file | cat) on Linux.
Root Cause
ensure_stdout_not_broken() used POLLRDBAND which doesn't work with standard Unix pipes, causing improper pipe state detection.
Solution
Changed poll flag from POLLRDBAND to POLLOUT:
Correctly detects broken pipes via POLLERR (automatically checked by poll)
Uses zero timeout (non-blocking)
Properly handles both healthy and broken pipes
Changes
signals.rs: Updated ensure_stdout_not_broken() to use POLLOUT
tee.rs: Restored pre-check with better documentation
test_tee.rs: Added regression test test_pipe_mode_normal_pipeline_no_hang