od:fix od -v /dev/zero panic #10576
Open
od:fix od -v /dev/zero panic #10576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added generic `W: Write` parameter to `print_final_offset()` method - Updated all `odfunc()` calls to pass output writer explicitly - Replaced direct `println!()` calls with `writeln!(out, ...)` throughout - Enables dependency injection for output streams in tests - Maintains existing functionality while improving testability
Reformatted the `odfunc` call to improve code readability by breaking it into multiple lines with proper indentation. This change enhances code maintainability without altering functionality.
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix this issue
related
#10574