Skip to content

Conversation

@RenjiSann
Copy link
Collaborator

Fixes the issue raised in #10142 (comment)

Basically, this change does 3 things:

  • Embeds checksum_common en_US locales in uucore at build time if necessary.
  • Make init_localization look for checksum_common locales.
  • Install extra locales for checksum_common when running make install.

cc @oech3

@RenjiSann RenjiSann requested a review from sylvestre January 30, 2026 11:04
@oech3
Copy link
Contributor

oech3 commented Jan 30, 2026

We have sum command, but is .ends_with("sum") OK if we don't use ck-* translations?

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/basenc/bounded-memory is now passing!

@RenjiSann
Copy link
Collaborator Author

We have sum command, but is .ends_with("sum") OK if we don't use ck-* translations?

Good catch. It's not problematic: we will just include the common locales for it even though it doesn't need it.
Actually, I never looked at sum, maybe we can port it to the common implementation as well

@oech3
Copy link
Contributor

oech3 commented Jan 31, 2026

Does release/debug profile specific regression test works correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants