feat(uucore): Add locale detection from LC_ALL and LC_MESSAGES
#10570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fix #8922.
Implementation :
When creating the locale string, check in this order :
LC_ALL->LC_MESSAGES->LANGAccording to the documentation on the precedence of each variable.
Important note : I did not include the
LANGUAGEvariable as it seems more specific to gettext and does not follow the the same pattern as the other variables (specify multiple languages).Testing :
I'm using the devcontainer.
For completeness, here is the result of the
localecommand inside the container:Built successfully with
Ran tests with no error
Tried all these combinations which output the correct language