feat: add yandex storage adapter #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
All tests were successful |
|
@stnguyen90 Can you check it? |
|
Can you check it please? @shimonewman @eldadfux |
stnguyen90
requested changes
Nov 13, 2023
Contributor
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
Please fix the linting errors.
…/hydromoll/storage into feat-7026-Yandex-storage-adapter
|
@stnguyen90 Can you check corrections? |
|
Can you check it please? |
stnguyen90
requested changes
Nov 21, 2023
phpunit.xml
Outdated
| <testsuite name="unit"> | ||
| <directory>./tests/Storage/Compression</directory> | ||
| <file>./tests/Storage/Device/LocalTest.php</file> | ||
| <file>./tests/Storage/Device/YandexTest.php</file> |
Contributor
There was a problem hiding this comment.
This isn't needed. It should be included automatically in the e2e test suite. Also, tests against a 3rd party service should definitely not be in unit tests.
|
@stnguyen90 Can you give a review please? |
|
Dear moderators, can you make a review? |
|
@stnguyen90 Can you check it please?^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: