-
Notifications
You must be signed in to change notification settings - Fork 3
CHore: Upgrade to latest Appwrite #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the Appwrite dependency version constraint in composer.json from 11.* to 15.* and extend the runtime mapping in the Appwrite migration logic by adding new runtime keys while removing the deprecated 'dotnet-3.1' runtime. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
composer.json (1)
28-28: Prefer caret constraints for clearer intentUsing
"15.*"works, but the Composer-idiomatic form is"^15.0"—equivalent behavior, yet more explicit about following SemVer.- "appwrite/appwrite": "15.*", + "appwrite/appwrite": "^15.0",Optional, but helps future readers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
composer.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
composer.json(1 hunks)src/Migration/Destinations/Appwrite.php(0 hunks)
💤 Files with no reviewable changes (1)
- src/Migration/Destinations/Appwrite.php
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: ItzNotABug
PR: utopia-php/migration#80
File: src/Migration/Sources/Appwrite/Reader/API.php:8-8
Timestamp: 2025-06-28T09:47:11.436Z
Learning: In the Appwrite migration codebase, commented-out Tables service references (import statements and constructor parameters) are intentionally kept for future implementation when the Tables service becomes available in the Appwrite SDK, rather than being dead code that should be removed.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Run Test Suite
🔇 Additional comments (1)
composer.json (1)
28-28: Validate breaking-change surface introduced by Appwrite 15.xJumping four major versions (11 → 15) is likely to introduce BC breaks in the SDK API as well as in generated models and enums.
Please make sure the following are done before merging:
composer update appwrite/appwrite && vendor/bin/phpunitpasses locally.- Static analysis (
vendor/bin/phpstan) still reports level 3 clean.- Manual smoke test of the migration CLI against a live Appwrite 1.5+ instance.
If any of these fail, keep the upgrade on a feature branch until the necessary refactors land.
Summary by CodeRabbit
Chores
New Features
Bug Fixes