Skip to content

Csv perf poc #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ItzNotABug wants to merge 2 commits into from
Closed

Csv perf poc #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c62557
update: improve logic.
ItzNotABug Jul 4, 2025
6c5f600
add: benchmarking test.
ItzNotABug Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
278 changes: 165 additions & 113 deletions src/Migration/Sources/CSV.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ class CSV extends Source

private bool $downloaded = false;

// caching
private ?array $cachedAttributes = null;

private ?array $attributeMetadata = null;

public function __construct(
string $resourceId,
string $filePath,
Expand Down Expand Up @@ -120,73 +125,19 @@ protected function exportGroupDatabases(int $batchSize, array $resources): void
*/
private function exportDocuments(int $batchSize): void
{
$this->loadAndCacheAttributes($batchSize);

$attributes = [];
$lastAttribute = null;

[$databaseId, $collectionId] = explode(':', $this->resourceId);
$database = new Database($databaseId, '');
$collection = new Collection($database, '', $collectionId);

while (true) {
$queries = [$this->database->queryLimit($batchSize)];
if ($lastAttribute) {
$queries[] = $this->database->queryCursorAfter($lastAttribute);
}

$fetched = $this->database->listAttributes($collection, $queries);
if (empty($fetched)) {
break;
}

array_push($attributes, ...$fetched);
$lastAttribute = $fetched[count($fetched) - 1];

if (count($fetched) < $batchSize) {
break;
}
}

$arrayKeys = [];
$attributeTypes = [];
$manyToManyKeys = [];

foreach ($attributes as $attribute) {
$key = $attribute['key'];
$type = $attribute['type'];
$isArray = $attribute['array'] ?? false;
$relationSide = $attribute['side'] ?? '';
$relationType = $attribute['relationType'] ?? '';

if (
$type === Attribute::TYPE_RELATIONSHIP &&
$relationSide === UtopiaDatabase::RELATION_SIDE_CHILD
) {
continue;
}

$attributeTypes[$key] = $type;
[$databaseId, $collectionId] = explode(":", $this->resourceId);
$database = new Database($databaseId, "");
$collection = new Collection($database, "", $collectionId);

if (
$type === Attribute::TYPE_RELATIONSHIP &&
$relationType === 'manyToMany' &&
$relationSide === 'parent'
) {
$manyToManyKeys[] = $key;
}

if ($isArray && $type !== Attribute::TYPE_RELATIONSHIP) {
$arrayKeys[] = $key;
}
}

$this->withCSVStream(function ($stream) use ($attributeTypes, $manyToManyKeys, $arrayKeys, $collection, $batchSize) {
$this->withCsvStream(function ($stream) use ($batchSize, $collection) {
$headers = fgetcsv($stream);
if (! is_array($headers) || count($headers) === 0) {
return;
}

$this->validateCSVHeaders($headers, $attributeTypes);
$this->validateCSVHeaders($headers, array_column($this->attributeMetadata, 'type'));

$buffer = [];

Expand All @@ -200,59 +151,7 @@ private function exportDocuments(int $batchSize): void
continue;
}

$parsedData = $data;

foreach ($data as $key => $value) {
$parsedValue = trim($value);
$type = $attributeTypes[$key] ?? null;

if (! isset($type)) {
continue;
}

if (in_array($key, $manyToManyKeys, true)) {
$parsedData[$key] = $parsedValue === ''
? []
: array_values(
array_filter(
array_map(
'trim',
explode(',', $parsedValue)
)
)
);
continue;
}

if (in_array($key, $arrayKeys, true)) {
if ($parsedValue === '') {
$parsedData[$key] = [];
} else {
$arrayValues = str_getcsv($parsedValue);
$arrayValues = array_map('trim', $arrayValues);

$parsedData[$key] = array_map(function ($item) use ($type) {
return match ($type) {
Attribute::TYPE_INTEGER => is_numeric($item) ? (int) $item : null,
Attribute::TYPE_FLOAT => is_numeric($item) ? (float) $item : null,
Attribute::TYPE_BOOLEAN => filter_var($item, FILTER_VALIDATE_BOOLEAN),
default => $item,
};
}, $arrayValues);
}
continue;
}

if ($parsedValue !== '') {
$parsedData[$key] = match ($type) {
Attribute::TYPE_INTEGER => is_numeric($parsedValue) ? (int) $parsedValue : null,
Attribute::TYPE_FLOAT => is_numeric($parsedValue) ? (float) $parsedValue : null,
Attribute::TYPE_BOOLEAN => filter_var($parsedValue, FILTER_VALIDATE_BOOLEAN),
default => $parsedValue,
};
}
}

$parsedData = $this->parseRow($data);
$documentId = $parsedData['$id'] ?? 'unique()';

// `$id`, `$permissions` in the doc can cause issues!
Expand Down Expand Up @@ -313,6 +212,159 @@ protected function exportGroupFunctions(int $batchSize, array $resources): void
throw new \Exception('Not Implemented');
}

/**
* @param int $batchSize
* @return void
* @throws Exception
* @throws \Utopia\Database\Exception
*/
private function loadAndCacheAttributes(int $batchSize): void
{
if ($this->cachedAttributes !== null) {
return;
}

[ $databaseId, $collectionId ] = explode(":", $this->resourceId);

$database = new Database($databaseId, "");
$collection = new Collection($database, "", $collectionId);

$attributes = [];
$lastAttribute = null;

while (true) {
$queries = [$this->database->queryLimit($batchSize)];
if ($lastAttribute) {
$queries[] = $this->database->queryCursorAfter($lastAttribute);
}

$fetched = $this->database->listAttributes($collection, $queries);
if (empty($fetched)) {
break;
}

array_push($attributes, ...$fetched);
$lastAttribute = $fetched[count($fetched) - 1];

if (count($fetched) < $batchSize) {
break;
}
}

$this->cachedAttributes = $attributes;
$this->preprocessAttributes();
}

/**
* @return void
*/
private function preprocessAttributes(): void
{
$this->attributeMetadata = [];

foreach ($this->cachedAttributes as $attribute) {
$key = $attribute["key"];
$type = $attribute["type"];
$isArray = $attribute["array"] ?? false;
$relationSide = $attribute["side"] ?? "";
$relationType = $attribute["relationType"] ?? "";

if (
$type === Attribute::TYPE_RELATIONSHIP &&
$relationSide === UtopiaDatabase::RELATION_SIDE_CHILD
) {
continue;
}

$this->attributeMetadata[$key] = [
"type" => $type,
"isArray" => $isArray && $type !== Attribute::TYPE_RELATIONSHIP,
"isManyToMany" =>
$type === Attribute::TYPE_RELATIONSHIP &&
$relationType === "manyToMany" &&
$relationSide === "parent",
];
}
}

/**
* @param array $data
* @return array
*/
private function parseRow(array $data): array
{
$parsedData = [];

foreach ($data as $key => $value) {
$parsedValue = trim($value);

if (!isset($this->attributeMetadata[$key])) {
continue;
}

$metadata = $this->attributeMetadata[$key];
$type = $metadata["type"];

if ($metadata["isManyToMany"]) {
$parsedData[$key] = $parsedValue === ''
? []
: array_values(
array_filter(
array_map(
'trim',
explode(',', $parsedValue)
)
)
);
continue;
}

// array attributes
if ($metadata["isArray"]) {
if ($parsedValue === "") {
$parsedData[$key] = [];
} else {
$arrayValues = str_getcsv($parsedValue);
$arrayValues = array_map('trim', $arrayValues);
$parsedData[$key] = $this->convertScalars($arrayValues, $type, true);
}
continue;
}

// normal attributes
if ($parsedValue !== "") {
$parsedData[$key] = $this->convertScalars($parsedValue, $type);
} else {
$parsedData[$key] = $parsedValue;
}
}

return $parsedData;
}

private function convertScalars(mixed $value, string $type, bool $isArray = false): mixed
{
$values = is_array($value) ? $value : [$value];

$converted = match ($type) {
Attribute::TYPE_INTEGER => array_map(
fn ($v) => ($v = trim($v)) !== '' && is_numeric($v) ? (int) $v : null,
$values
),
Attribute::TYPE_FLOAT => array_map(
fn ($v) => ($v = trim($v)) !== '' && is_numeric($v) ? (float) $v : null,
$values
),
Attribute::TYPE_BOOLEAN => array_map(
fn ($v) => filter_var(trim($v), FILTER_VALIDATE_BOOLEAN),
$values
),
default => array_map('trim', $values),
};

return $isArray ? $converted : $converted[0];
}

/**
* @param callable(resource $stream): void $callback
* @return void
Expand Down
Loading