Fix database column input normalization - #219
Merged
Merged
Conversation
Contributor
Greptile SummaryThe PR normalizes database-reader column documents into arrays at the existing Appwrite source boundary while preserving the established column resolution logic.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The normalization occurs before the existing column resolution path, preserves array inputs unchanged, and the regression test directly covers the database-document failure being fixed. Important Files Changed
Reviews (1): Last reviewed commit: "(fix): normalize database column input" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Utopia\Database\Documentcolumn records at the existing Appwrite source boundaryVerification
TypeError: Column::resolve(): Argument #1 ($column) must be of type array, Utopia\Database\Document givencomposer formatcomposer lintcomposer checkThe host-only full test command cannot run the eight NHost/Supabase E2E cases without their database services; the isolated Compose run supplied those services and passed the complete suite.