Skip to content

fix(destination): skip project variables with unusable keys #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
levivannoort merged 1 commit into from
Aug 12, 2026
Merged

fix(destination): skip project variables with unusable keys #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions src/Migration/Destinations/Appwrite.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,14 @@ class Appwrite extends Destination

private const VECTORSDB_EMBEDDINGS_KEY = 'embeddings';

/**
* Variable keys become environment variable names at build and runtime, so
* the API only accepts C-style identifiers. Variables are written straight
* to the collection here, which skips that check, and a source project can
* still hold a key stored before the rule existed.
*/
private const VARIABLE_KEY_PATTERN = '/^[A-Za-z_]\w*$/D';

/** A database is provisioning while its resources transfer, ready once the run completes, or failed if creation errored. */
private const DATABASE_STATUS_PROVISIONING = 'provisioning';
private const DATABASE_STATUS_READY = 'ready';
Expand Down Expand Up @@ -3344,9 +3352,23 @@ public function importDomainsResource(Resource $resource): Resource

protected function createProjectVariable(ProjectVariable $resource): bool
{
$key = $resource->getKey();

if (
\strlen($key) > UtopiaDatabase::LENGTH_KEY
|| \preg_match(self::VARIABLE_KEY_PATTERN, $key) !== 1
) {
$resource->setStatus(
Resource::STATUS_SKIPPED,
'Project variable key is not a valid environment variable name'
);

return false;
}

$existing = $this->dbForProject->findOne('variables', [
Query::equal('resourceType', ['project']),
Query::equal('key', [$resource->getKey()]),
Query::equal('key', [$key]),
]);

if ($existing !== false && !$existing->isEmpty()) {
Expand All @@ -3357,7 +3379,6 @@ protected function createProjectVariable(ProjectVariable $resource): bool
$createdAt = $this->normalizeDateTime($resource->getCreatedAt());
$updatedAt = $this->normalizeDateTime($resource->getUpdatedAt(), $createdAt);
$variableId = ID::unique();
$key = $resource->getKey();

try {
$this->dbForProject->createDocument('variables', new UtopiaDocument([
Expand Down
Loading