Skip to content

Storage calculations #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fogelito wants to merge 3 commits into
base: main
Choose a base branch
from
+20 −20
Open

Storage calculations #930

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
494855e
Use union all
fogelito Aug 5, 2026
e9d3b14
throw
fogelito Aug 5, 2026
6f8f0d6
Merge branch 'main' of github.com:utopia-php/database into storage-calc
fogelito Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions src/Database/Adapter/MariaDB.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,34 +283,34 @@ public function getSizeOfCollection(string $collection): int
$database = $this->getDatabase();
$permissions = $collection . '_perms';

$collectionSize = $this->getPDO()->prepare("
SELECT SUM(data_length + index_length)
FROM INFORMATION_SCHEMA.TABLES
WHERE table_name = :name AND
table_schema = :database
");

$permissionsSize = $this->getPDO()->prepare("
SELECT SUM(data_length + index_length)
FROM INFORMATION_SCHEMA.TABLES
WHERE table_name = :permissions AND
table_schema = :database
// Both tables in one round trip. Keep the equality predicates: LIKE and IN are
// not indexed here, they scan every table in the schema.
$statement = $this->getPDO()->prepare("
SELECT SUM(size) FROM (
SELECT data_length + index_length AS size
FROM INFORMATION_SCHEMA.TABLES
WHERE table_name = :name AND
table_schema = :database
UNION ALL
SELECT data_length + index_length AS size
FROM INFORMATION_SCHEMA.TABLES
WHERE table_name = :permissions AND
table_schema = :database
) AS sizes
");

$collectionSize->bindParam(':name', $collection);
$collectionSize->bindParam(':database', $database);
$permissionsSize->bindParam(':permissions', $permissions);
$permissionsSize->bindParam(':database', $database);
$statement->bindParam(':name', $collection);
$statement->bindParam(':permissions', $permissions);
$statement->bindParam(':database', $database);
Comment on lines +293 to +304

@coderabbitai coderabbitai Bot Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

rg -n -C 5 'PDO::ATTR_EMULATE_PREPARES|ATTR_EMULATE_PREPARES|new PDO\s*\(' . || true
rg -n -C 4 'table_schema = :database|bindParam.*:database' \
  src/Database/Adapter/MariaDB.php

Repository: utopia-php/database

Length of output: 19931

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '%s\n' '--- MariaDB adapter structure and relevant methods ---'
ast-grep outline src/Database/Adapter/MariaDB.php
rg -n -C 12 'function __construct|function getPDOAttributes|getMaxIndexLength|table_schema = :database|bindParam' \
  src/Database/Adapter/MariaDB.php src/Database/Adapter/SQL.php

printf '%s\n' '--- PDO construction and attribute overrides ---'
rg -n -C 8 'new PDO|ATTR_EMULATE_PREPARES|setAttribute|prepare\s*\(' \
  src tests bin README.md -g '*.php' -g '*.md' | head -n 500

printf '%s\n' '--- Standalone PHP environment and marker probe ---'
if command -v php >/dev/null 2>&1; then
  php -r 'echo "PHP ", PHP_VERSION, PHP_EOL; echo "PDO drivers: ", implode(",", PDO::getAvailableDrivers()), PHP_EOL;'
  php <<'PHP'
<?php
$sql = <<<'SQL'
SELECT SUM(size) FROM (
    SELECT data_length + index_length AS size
    FROM INFORMATION_SCHEMA.TABLES
    WHERE table_name = :name AND table_schema = :database
    UNION ALL
    SELECT data_length + index_length AS size
    FROM INFORMATION_SCHEMA.TABLES
    WHERE table_name = :permissions AND table_schema = :database
) AS sizes
SQL;

foreach (PDO::getAvailableDrivers() as $driver) {
    try {
        $dsn = $driver === 'sqlite' ? 'sqlite::memory:' : null;
        if ($dsn === null) {
            continue;
        }
        foreach ([true, false] as $emulate) {
            $pdo = new PDO($dsn, null, null, [
                PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION,
                PDO::ATTR_EMULATE_PREPARES => $emulate,
            ]);
            try {
                $stmt = $pdo->prepare($sql);
                echo "$driver emulate=" . ($emulate ? 'true' : 'false')
                    . " prepare=ok parameter_count=" . $stmt->parameterCount() . PHP_EOL;
            } catch (Throwable $e) {
                echo "$driver emulate=" . ($emulate ? 'true' : 'false')
                    . " prepare=" . get_class($e) . ': ' . $e->getMessage() . PHP_EOL;
            }
        }
    } catch (Throwable $e) {
        echo "$driver setup=" . get_class($e) . ': ' . $e->getMessage() . PHP_EOL;
    }
}
PHP
else
  echo 'php unavailable'
fi

Repository: utopia-php/database

Length of output: 42315

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '%s\n' '--- PDO wrapper and adapter connection access ---'
ast-grep outline src/Database/PDO.php src/Database/PDOStatement.php src/Database/Adapter/SQL.php
rg -n -C 15 'class PDO|class PDOStatement|function __construct|function getPDO|function reconnect|ATTR_EMULATE_PREPARES|prepareNative|__call' \
  src/Database/PDO.php src/Database/PDOStatement.php src/Database/Adapter/SQL.php

printf '%s\n' '--- Constructor and documented connection contract ---'
rg -n -C 10 'new MariaDB|MariaDB\(|Utopia\\Database\\PDO|Database\\PDO|setAttribute|ATTR_EMULATE_PREPARES' \
  README.md docs src tests bin composer.json composer.lock 2>/dev/null || true

printf '%s\n' '--- PDO attribute configuration definitions ---'
rg -n -C 8 'getPDOAttributes|pdoAttr|attrs' bin src tests -g '*.php'

Repository: utopia-php/database

Length of output: 50376

🌐 Web query:

PHP PDO::prepare named parameter marker cannot be used more than once in a prepared statement emulated prepares

💡 Result:

By default, PHP PDO prepared statements do not allow a named parameter marker to be used more than once in a single SQL statement [1][2]. When native prepared statements are used, the database driver expects each parameter marker to correspond to a unique binding, and repeating the same name will typically cause an error or unexpected behavior because the underlying database API cannot map multiple occurrences of the same name to the same value [3]. However, you can use the same named parameter multiple times if you enable emulated prepared statements [1][4]. This is done by setting the PDO::ATTR_EMULATE_PREPARES attribute to true [5][4]: $pdo->setAttribute(PDO::ATTR_EMULATE_PREPARES, true); When emulation mode is enabled, PDO does not send the query to the database server during the prepare phase [6]. Instead, it parses the SQL string in PHP, manually replaces the named placeholders with the provided values (using quoting where necessary), and sends the resulting fully-formed query to the database for execution [3][6]. Because this substitution happens entirely within PHP before the query is sent to the database, the restriction on repeating placeholders is bypassed [3]. While enabling emulation mode allows for repetitive named parameters, it is important to be aware of the trade-offs: 1. Security: While emulated prepares still protect against SQL injection by properly quoting values, native prepared statements are generally preferred as they provide a more robust separation of query logic and data at the database engine level [1][5]. 2. Behavior: Emulated prepares do not perform server-side validation of the SQL syntax during the prepare phase, meaning you may only discover syntax errors when the query is actually executed [6]. If you prefer to keep emulation mode disabled (the default in most modern PDO configurations), the standard solution is to use unique names for each placeholder (e.g.,:name1,:name2) and bind the same value to each one [2][4].

Citations:

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '%s\n' '--- SQL connection storage and access ---'
sed -n '1,115p' src/Database/Adapter/SQL.php
rg -n -C 8 'function getPDO|function __construct|protected .*pdo|public .*pdo' src/Database/Adapter/SQL.php

printf '%s\n' '--- PDO wrapper API ---'
sed -n '1,150p' src/Database/PDO.php
sed -n '150,330p' src/Database/PDO.php
printf '%s\n' '--- PDO statement binding API ---'
rg -n -C 6 'class PDOStatement|function bindParam|function bindValue|function execute|function __construct|prepareNative' \
  src/Database/PDOStatement.php src/Database/PDO.php

printf '%s\n' '--- MariaDB construction and PDO usage ---'
sed -n '1,45p' src/Database/Adapter/MariaDB.php
rg -n -C 5 'getPDO\(\)->prepare|new MariaDB|new \\?PDO|new PDO|ATTR_EMULATE_PREPARES' \
  src/Database/Adapter/MariaDB.php src/Database/PDO.php README.md tests/e2e/Adapter/MariaDBTest.php

Repository: utopia-php/database

Length of output: 38641

Use distinct PDO markers for the two schema predicates.

When native prepares are enabled, PDO does not support reusing :database. MariaDB accepts caller-supplied PDO connections, so the emulated-prepare default is not enforced. Bind $database to two distinct markers.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/Database/Adapter/MariaDB.php` around lines 293 - 304, Update the SQL in
the MariaDB adapter’s size query to use distinct PDO placeholders for each
table_schema predicate, then bind $database to both markers in the adjacent
bindParam calls. Keep the existing $collection and $permissions bindings
unchanged.

Source: MCP tools


try {
$collectionSize->execute();
$permissionsSize->execute();
$size = $collectionSize->fetchColumn() + $permissionsSize->fetchColumn();
$statement->execute();
$size = $statement->fetchColumn();
} catch (PDOException $e) {
throw new DatabaseException('Failed to get collection size: ' . $e->getMessage());
}

return $size;
return (int) $size;
}

/**
Expand Down
Loading