Remove the Proxy cache adapter - #7
Merged
Merged
Conversation
Greptile SummaryRemoves the unused topology-specific cache routing adapter and its associated documentation and tests.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "Remove the Proxy cache adapter" | Re-trigger Greptile |
Cache\Adapter\Proxy hard-codes one deployment's routing into the library: an app domain, a set of network domains, and a list of adapters for everything else. Any consumer whose split is not exactly that cannot use it, and a consumer whose split is that has encoded its topology in a dependency it does not control. #4 has since established that it cannot route key purges at all, since keys are scoped to a service or zone, and told consumers to select the adapter themselves before constructing Cache. That is the same conclusion for every operation, not only keys. Nothing uses it. Its only references were its own test and the README. Certificates\Provider\Proxy is untouched; this removes the cache adapter only. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Meldiron
force-pushed
the
remove-cache-proxy
branch
from
August 13, 2026 18:54
2e2c1eb to
15d52ed
Compare
TorstenDittmann
approved these changes
Aug 13, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Deletes
Cache\Adapter\Proxy.It hard-codes one deployment's routing into the library:
An app domain, a set of network domains, and a list of adapters for everything else. A consumer whose split is not exactly that cannot use it; a consumer whose split is that has encoded its own topology in a dependency it does not control, and has to ship a library release to change it.
#4 has since established that it cannot route key purges at all — keys are scoped to a Fastly service or a Cloudflare zone, so
purgeKeys()now throws and the README tells consumers to pick the adapter themselves before constructingCache:That is the right conclusion, and it is not specific to keys. Once the consumer is resolving the adapter for one operation it holds the routing context for all of them, and what is left of
Proxyis a domain-shaped special case of something the consumer already does.Nothing uses it. Its only references anywhere were its own test and the README section documenting it — no other class in this library, and no usage in appwrite-labs/cloud, which routes purges itself.
Certificates\Provider\Proxyis a different class and is untouched.Exception\ConfigurationandException\UnsupportedOperationboth stay, since the certificate providers still use them.Test Plan
composer test— 22 tests, 45 assertions, down from 26/49 onmain: the four removed areProxyTest's own, and every other test passes untouched, which is the evidence that nothing depended on it.composer analyse(level 6) reports[OK] No errors— relevant here because PHPStan would flag any surviving reference to the deleted class.composer lintpasses.I checked for usage by grepping this repository and appwrite-labs/cloud for
Adapter\Proxy,Adapter/Proxyandnew Proxy(outside the certificates namespace; the only hits were the two files this PR deletes and the README section it removes.Breaking changes
Removing a public class is breaking for anyone constructing it. The library is
0.0.xand the class is unreferenced in the only consumer I know of.Related PRs and Issues
Groundwork for #5, which introduces a filter-based
Cache\Adapter\Balancercovering the same fan-out need without the library holding a topology.Note for ordering: #6 currently adds a method to
Proxy, so it will need a rebase once this merges — the conflict resolves by dropping that part of it.Checklist
composer lintcomposer analysecomposer test🤖 Generated with Claude Code